Fix chromeless and inline url use #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
+ Coverage 78.46% 80.19% +1.73%
==========================================
Files 462 635 +173
Lines 31611 47414 +15803
Branches 754 745 -9
==========================================
+ Hits 24802 38026 +13224
- Misses 6726 9305 +2579
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryan-pratt
approved these changes
Jun 30, 2025
clayandgen
approved these changes
Jun 30, 2025
jmthomas
approved these changes
Jun 30, 2025
| @@ -406,14 +406,22 @@ export default { | |||
| updatePackets: function () { | |||
| if (this.selectedTargetName === 'UNKNOWN') { | |||
| this.packetNames = [this.UNKNOWN] | |||
| this.selectedPacketName = this.packetNames[0].value | |||
| if (this.packetNames.length === 0) { | |||
There was a problem hiding this comment.
Not sure why this check is here because we set this.packetNames = [this.UNKNOWN] so it is always length 1
ryan-pratt
approved these changes
Jun 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chromeless mode on Core. Also fix a couple minor bugs (target with no commands in cmdsender)
Also enables defining a plugin tool that opens in a new window but is still "inline"