-
Notifications
You must be signed in to change notification settings - Fork 51
Add range
arg option to get_object calls
#2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
+ Coverage 80.17% 80.18% +0.01%
==========================================
Files 636 636
Lines 47604 47604
Branches 754 754
==========================================
+ Hits 38166 38171 +5
+ Misses 9355 9350 -5
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -118,15 +118,15 @@ def delete(self, bucket): | |||
if self.exist(bucket): | |||
self.client.delete_bucket(Bucket=bucket) | |||
|
|||
def get_object(self, bucket, key, path=None): | |||
def get_object(self, bucket, key, path=None, range=""): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should range = "" or None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing Range=None
to python Boto3 causes an error, so defaulting to a string here
|
The following get_object lookups have been tested with Minio and AWS S3: