Clear screenItems when re-parsing screen definition #2101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 79.80% 79.79% -0.01%
==========================================
Files 633 633
Lines 47968 48026 +58
Branches 754 754
==========================================
+ Hits 38281 38324 +43
- Misses 9604 9619 +15
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ryan-pratt
commented
May 30, 2025
| @@ -442,6 +451,7 @@ export default { | |||
| parseDefinition: function () { | |||
| // Each time we start over and parse the screen definition | |||
| this.clearErrors() | |||
| this.screenItems = [] | |||
There was a problem hiding this comment.
This is the actual fix. The rest of the changes are just linter things
ryanmelt
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items were not being cleared when a screen is rendered, meaning that if you added an item that doesn't exist, the error alerting you to that fact would persist until you completely closed and reopened the screen (even after removing the bad item from the screen definition and clicking "save"). Clearing out
screenItemswhen the screen definition is parsed fixes this, so all you have to do to clear the error is save the screen: