Skip to content

Remove extra : in toast notification when there's no body #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

ryan-pratt
Copy link
Contributor

This way it's just {title} instead of {title}:. The : is still there when there's a body

image image

@ryan-pratt ryan-pratt requested a review from jmthomas May 14, 2025 18:41
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (b98c9bf) to head (ad29747).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
+ Coverage   79.15%   79.16%   +0.01%     
==========================================
  Files         631      631              
  Lines       47536    47536              
  Branches      754      754              
==========================================
+ Hits        37627    37632       +5     
+ Misses       9826     9821       -5     
  Partials       83       83              
Flag Coverage Δ
python 84.15% <ø> (+0.04%) ⬆️
ruby-api 71.36% <ø> (ø)
ruby-backend 82.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-pratt ryan-pratt merged commit cef2d21 into main May 15, 2025
28 checks passed
@ryan-pratt ryan-pratt deleted the bug/toast-title branch May 15, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants