Skip to content

Conversation

clayandgen
Copy link
Contributor

Increases code coverage on Script Runner API to 64.2% (+38.5%).
Some of the code in running_script.rb requires heavy stubbing, looking to address that separately.
running_script.rb is quite a large file, and I was following the convention of One Ruby file -> One Spec file, but if you'd like me to break it out, please let me know!

@clayandgen clayandgen requested review from jmthomas and ryanmelt May 7, 2025 18:40
Copy link

sonarqubecloud bot commented May 7, 2025

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (e0fe708) to head (94f8281).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
+ Coverage   77.95%   79.16%   +1.20%     
==========================================
  Files         629      631       +2     
  Lines       47263    47536     +273     
  Branches      754      754              
==========================================
+ Hits        36843    37630     +787     
+ Misses      10337     9823     -514     
  Partials       83       83              
Flag Coverage Δ
python 84.15% <ø> (+0.10%) ⬆️
ruby-api 71.34% <100.00%> (+12.52%) ⬆️
ruby-backend 82.91% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome and no Sonarqube issues!

@jmthomas jmthomas merged commit 7f674e6 into main May 7, 2025
30 checks passed
@jmthomas jmthomas deleted the unit-tests/script-runner branch May 7, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants