Skip to content

[Unit Tests] - Cmd / Tlm Controllers #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2025
Merged

[Unit Tests] - Cmd / Tlm Controllers #2055

merged 6 commits into from
May 3, 2025

Conversation

clayandgen
Copy link
Contributor

  • Improving testing coverage on the Cmd-Tlm-API
  • Code Coverage increased by ~22.6% on this Plugin
  • Silenced logging while running tests for better testing experience
  • I'm using the "Standard Ruby" Extension for code formatting, if you all dislike it, let me know 👍

@clayandgen clayandgen requested review from jmthomas and ryanmelt May 2, 2025 20:11
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (4641f87) to head (344278e).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
+ Coverage   76.80%   78.01%   +1.21%     
==========================================
  Files         629      629              
  Lines       47228    47228              
  Branches      754      754              
==========================================
+ Hits        36272    36846     +574     
+ Misses      10873    10299     -574     
  Partials       83       83              
Flag Coverage Δ
python 84.09% <ø> (+0.01%) ⬆️
ruby-api 59.14% <ø> (+13.61%) ⬆️
ruby-backend 82.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to get this much coverage! Can you address the small sonarqube issues by adding comments to the Logger stub

Copy link

sonarqubecloud bot commented May 3, 2025

@ryanmelt ryanmelt merged commit 5795be2 into main May 3, 2025
30 of 33 checks passed
@ryanmelt ryanmelt deleted the unit-tests/cmd-tlm-api branch May 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants