Skip to content

Move root redirect to nav guard #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Move root redirect to nav guard #2048

merged 1 commit into from
Apr 30, 2025

Conversation

ryan-pratt
Copy link
Contributor

@ryan-pratt ryan-pratt commented Apr 29, 2025

This fixes the issue where going to the route '/' did not reliably redirect you to the first tool. I don't want this redirect to get hung up on a slow API response, so I added a timeout of 150ms before it gives up and goes to a hardcoded cmdtlmserver

Looks like this also fixes this todo.

Will also need the same change made in Enterprise once this PR is approved

@ryan-pratt ryan-pratt requested review from jmthomas and ryanmelt April 29, 2025 22:50
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (4641f87) to head (34c299e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
- Coverage   76.80%   76.77%   -0.03%     
==========================================
  Files         629      629              
  Lines       47228    47228              
  Branches      754      754              
==========================================
- Hits        36272    36259      -13     
- Misses      10873    10886      +13     
  Partials       83       83              
Flag Coverage Δ
python 84.00% <ø> (-0.09%) ⬇️
ruby-api 45.53% <ø> (ø)
ruby-backend 82.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when we can fix a bug and resolve a TODO!

@ryan-pratt ryan-pratt merged commit 1a85760 into main Apr 30, 2025
29 of 30 checks passed
@ryan-pratt ryan-pratt deleted the bug/root-redirect branch April 30, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants