Skip to content

Don't make path clickable in Bucket Explorer #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

Don't make path clickable in Bucket Explorer #2041

merged 1 commit into from
Apr 26, 2025

Conversation

jmthomas
Copy link
Member

Previously the slash and the space around the slash was clickable which caused weird issues if you clicked it. I also fixed a bug when uploading to the root where it would append an extra slash.
Screenshot 2025-04-25 at 2 59 37 PM

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.76%. Comparing base (db1008d) to head (9fb3db5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
- Coverage   76.77%   76.76%   -0.02%     
==========================================
  Files         629      629              
  Lines       47224    47228       +4     
  Branches      754      754              
==========================================
- Hits        36258    36256       -2     
- Misses      10883    10889       +6     
  Partials       83       83              
Flag Coverage Δ
python 83.98% <ø> (-0.03%) ⬇️
ruby-api 45.53% <ø> (ø)
ruby-backend 82.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me!

@jmthomas jmthomas merged commit 51156e2 into main Apr 26, 2025
30 checks passed
@jmthomas jmthomas deleted the bucket branch April 26, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants