Fix DISABLE_DISCONNECT in the frontend #1972
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
+ Coverage 76.66% 76.82% +0.16%
==========================================
Files 628 628
Lines 46547 46560 +13
Branches 755 755
==========================================
+ Hits 35684 35769 +85
+ Misses 10780 10708 -72
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -51,7 +51,7 @@ | |||
| <v-btn | |||
| block | |||
| color="primary" | |||
| :disabled="buttonsDisabled" | |||
| :disabled="buttonsDisabled || (item.disable_disconnect && item.connected === 'CONNECTED')" | |||
There was a problem hiding this comment.
I think we should add a tooltip to say that it's disabled due to the interface config
There was a problem hiding this comment.
Good idea because otherwise it's like ... why is this disabled?!
| @@ -80,6 +80,7 @@ VARIABLE reduced_log_retain_time 2592000 | |||
| <% if include_inst and include_inst_int %> | |||
| INTERFACE <%= inst_int_name %> simulated_target_interface.rb sim_inst.rb | |||
| MAP_TARGET <%= inst_target_name %> | |||
| DISABLE_DISCONNECT | |||
There was a problem hiding this comment.
I don't want the demo to have DISABLE_DISCONNECT set on anything.
There was a problem hiding this comment.
I thought the Demo philosophy was to test all the options ... that's why we didn't know this didn't work. :-)
There was a problem hiding this comment.
To a point. This makes the demo annoying so I'm vetoing.
|
|
closes #1971