Skip to content

Conversation

jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested review from ryan-pratt and ryanmelt March 25, 2025 17:35
@@ -1,6 +1,6 @@
ARG OPENC3_DEPENDENCY_REGISTRY=docker.io
# Consider updating openc3_build_ubi.sh when changing the release version
ARG OPENC3_MINIO_RELEASE=RELEASE.2025-01-20T14-49-07Z
ARG OPENC3_MINIO_RELEASE=RELEASE.2025-03-12T18-04-18Z
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the latest MINIO on Iron Bank continues to be the 1-20 version

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (6b1e32c) to head (f1c098b).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1969   +/-   ##
=======================================
  Coverage   76.68%   76.68%           
=======================================
  Files         628      628           
  Lines       46541    46541           
  Branches      755      755           
=======================================
  Hits        35690    35690           
  Misses      10768    10768           
  Partials       83       83           
Flag Coverage Δ
python 84.22% <ø> (ø)
ruby-api 48.41% <ø> (ø)
ruby-backend 82.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ryan-pratt ryan-pratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to fix the trivy scans, or will they still fail until Iron Bank gets the new Minio release?

"vue": "3.5.13",
"vue-eslint-parser": "9.4.3"
"vue-eslint-parser": "10.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: vue-eslint-parser mv update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping this would fix the trivy scans but it does not because apparently MINIO and traefik have not applied the fix.

@jmthomas
Copy link
Member Author

jmthomas commented Mar 25, 2025

Looks like MINIO just merged the fix here: minio/minio#21055 so the next release should be good and judging by their cadence it should be soon. Let's leave this open until we can update MINIO/MC and close these.

Here's the Traefik PR: traefik/traefik#11634

Copy link

@ryanmelt
Copy link
Member

Going to go ahead and merge this. We can have a seperate PR for the minio/traefik fixes when available.

@ryanmelt ryanmelt merged commit 86c2ce3 into main Mar 27, 2025
29 of 30 checks passed
@ryanmelt ryanmelt deleted the dependencies branch March 27, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants