-
Notifications
You must be signed in to change notification settings - Fork 51
Update dependencies #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1969
Conversation
@@ -1,6 +1,6 @@ | |||
ARG OPENC3_DEPENDENCY_REGISTRY=docker.io | |||
# Consider updating openc3_build_ubi.sh when changing the release version | |||
ARG OPENC3_MINIO_RELEASE=RELEASE.2025-01-20T14-49-07Z | |||
ARG OPENC3_MINIO_RELEASE=RELEASE.2025-03-12T18-04-18Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the latest MINIO on Iron Bank continues to be the 1-20 version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
=======================================
Coverage 76.68% 76.68%
=======================================
Files 628 628
Lines 46541 46541
Branches 755 755
=======================================
Hits 35690 35690
Misses 10768 10768
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected to fix the trivy scans, or will they still fail until Iron Bank gets the new Minio release?
"vue": "3.5.13", | ||
"vue-eslint-parser": "9.4.3" | ||
"vue-eslint-parser": "10.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self: vue-eslint-parser mv update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping this would fix the trivy scans but it does not because apparently MINIO and traefik have not applied the fix.
Looks like MINIO just merged the fix here: minio/minio#21055 so the next release should be good and judging by their cadence it should be soon. Let's leave this open until we can update MINIO/MC and close these. Here's the Traefik PR: traefik/traefik#11634 |
|
Going to go ahead and merge this. We can have a seperate PR for the minio/traefik fixes when available. |
No description provided.