-
Notifications
You must be signed in to change notification settings - Fork 51
Parallel Playwright #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel Playwright #1945
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.02%
==========================================
Files 629 629
Lines 46733 46737 +4
Branches 755 755
==========================================
+ Hits 35911 35925 +14
+ Misses 10739 10729 -10
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs merge main, and fix to playwright.sh?
playwright/package.json
Outdated
"test:parallel": "playwright test ./tests/**/*.p.spec.ts --project=chromium", | ||
"test:serial": "playwright test ./tests/**/*.s.spec.ts --project=chromium --workers=1", | ||
"test:enterprise": "ENTERPRISE=1 playwright test ./tests/enterprise/*.spec.ts --project=chromium --workers=1", | ||
"test:keycloak": "playwright test ./tests/**/*.p.spec.ts --project=keycloak || playwright test ./tests/**/*.s.spec.ts --project=keycloak --workers=1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with the new keycloak
project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of the aws testing: https://github.com/OpenC3/cosmos/blob/main/playwright/playwright.sh#L52
await page | ||
.locator('[data-test=start-time] input') | ||
.fill(format(start, 'HH:mm:ss')) | ||
await page | ||
.locator('[data-test=end-date] input') | ||
.fill(format(date, 'yyyy-MM-dd')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this particular failure a few times now so good to merge and fix
;; | ||
|
||
run-enterprise ) | ||
yarn test:enterprise | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing ;;
otherwise, these could fail and the gh action will still pass as long as the serial tests pass
|
No description provided.