Skip to content

Parallel Playwright #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 28, 2025
Merged

Parallel Playwright #1945

merged 16 commits into from
Mar 28, 2025

Conversation

ryan-pratt
Copy link
Contributor

@ryan-pratt ryan-pratt commented Mar 5, 2025

No description provided.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (2650ba4) to head (80e4d01).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
+ Coverage   76.84%   76.86%   +0.02%     
==========================================
  Files         629      629              
  Lines       46733    46737       +4     
  Branches      755      755              
==========================================
+ Hits        35911    35925      +14     
+ Misses      10739    10729      -10     
  Partials       83       83              
Flag Coverage Δ
python 84.17% <ø> (+0.05%) ⬆️
ruby-api 48.48% <ø> (ø)
ruby-backend 82.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-pratt ryan-pratt marked this pull request as ready for review March 25, 2025 20:30
@ryan-pratt ryan-pratt requested a review from jmthomas March 26, 2025 15:36
Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs merge main, and fix to playwright.sh?

"test:parallel": "playwright test ./tests/**/*.p.spec.ts --project=chromium",
"test:serial": "playwright test ./tests/**/*.s.spec.ts --project=chromium --workers=1",
"test:enterprise": "ENTERPRISE=1 playwright test ./tests/enterprise/*.spec.ts --project=chromium --workers=1",
"test:keycloak": "playwright test ./tests/**/*.p.spec.ts --project=keycloak || playwright test ./tests/**/*.s.spec.ts --project=keycloak --workers=1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with the new keycloak project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await page
.locator('[data-test=start-time] input')
.fill(format(start, 'HH:mm:ss'))
await page
.locator('[data-test=end-date] input')
.fill(format(date, 'yyyy-MM-dd'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this particular failure a few times now so good to merge and fix

;;

run-enterprise )
yarn test:enterprise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing ;;

otherwise, these could fail and the gh action will still pass as long as
the serial tests pass
Copy link

@ryan-pratt ryan-pratt requested a review from ryanmelt March 28, 2025 19:18
@ryan-pratt ryan-pratt merged commit 8a0583d into main Mar 28, 2025
27 of 30 checks passed
@ryan-pratt ryan-pratt deleted the playwright branch March 28, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants