Skip to content

Fix python try except instrumentation #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2025
Merged

Fix python try except instrumentation #1940

merged 7 commits into from
Mar 7, 2025

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Mar 5, 2025

closes #1929

@jmthomas jmthomas requested review from ryanmelt and ryan-pratt March 5, 2025 00:28
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.71%. Comparing base (7d417f1) to head (4ce5ff0).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
- Coverage   76.72%   76.71%   -0.02%     
==========================================
  Files         628      628              
  Lines       46643    46637       -6     
  Branches      755      755              
==========================================
- Hits        35788    35777      -11     
- Misses      10772    10777       +5     
  Partials       83       83              
Flag Coverage Δ
python 84.18% <ø> (-0.04%) ⬇️
ruby-api 48.39% <ø> (ø)
ruby-backend 82.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case with multiple lines in a block. This doesn't seem right

Copy link

sonarqubecloud bot commented Mar 6, 2025

@ryanmelt ryanmelt merged commit 1ce65a0 into main Mar 7, 2025
29 of 32 checks passed
@ryanmelt ryanmelt deleted the py_except branch March 7, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scriptrunner errors and can't recover if a try/except block exists in the python script
3 participants