Skip to content

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Jan 31, 2024

This newest release has issues with double quotes in the platform selector in Windows builds (see here):

"D:\a\_actions\pypa\cibuildwheel\v2.16.4" cibuildwheel "." --output-dir '"dist"' --config-file '""' --only '""'
  pipx run --python "C:\hostedtoolcache\windows\Python\3.12.1\x64\python.exe" --spec "D:\a\_actions\pypa\cibuildwheel\v2.16.4" cibuildwheel "." --output-dir '"dist"' --config-file '""' --only '""'
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
  env:
    CIBW_TEST_COMMAND: 
    CIBW_BUILD: cp3*-win_amd64
    CIBW_ARCHS: auto
creating virtual environment...
determining package name from 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.16.4'...
creating virtual environment...
installing cibuildwheel from spec 'D:\\a\\_actions\\pypa\\cibuildwheel\\v2.16.4'...
Invalid --only='""', must be a build selector with a known platform
Error: Process completed with exit code 1.

To fix this, we can try using the newest hotfix release of pypa/cibuildwheel:
https://github.com/pypa/cibuildwheel/releases/tag/v2.16.5

🐛 Fix an incompatibility with the GitHub Action and new GitHub Runner images for Windows that bundle Powershell 7.3+ (pypa/cibuildwheel#1741)

@zacharyburnett zacharyburnett changed the title bumpy pypa/cibuildwheel to 2.16.5 to incorporate Windows build fixes bump pypa/cibuildwheel to 2.16.5 to incorporate Windows build fixes Jan 31, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review January 31, 2024 14:03
@ConorMacBride ConorMacBride linked an issue Jan 31, 2024 that may be closed by this pull request
@ConorMacBride ConorMacBride merged commit 70d7e14 into OpenAstronomy:main Jan 31, 2024
@ConorMacBride
Copy link
Member

Thanks @zacharyburnett!

@pllim
Copy link
Contributor

pllim commented Jan 31, 2024

Any plans to release a new version of this workflow? Or you waiting on something else (like maybe why old wheels not deleted)? Thanks!

@ConorMacBride
Copy link
Member

Thanks for the reminder. I just released a new version. We always use the main branch of the anaconda action, so any updates applied there will be available here immediately.

@zacharyburnett zacharyburnett deleted the fix/windows_build branch February 1, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: cp310*win_amd64 wheels failed with invalid --only

3 participants