Skip to content

Conversation

@ybelenko
Copy link
Contributor

I'm working on new PHP Symfony 5 server generator.

What I want to achieve with new generator:

  1. Remove all source Symfony files from templates because Composer installation writes them automatically for us.
  2. Change source files location, it slightly changed in Symfony 5.
  3. Remove custom serializers and other helper classes and replace them with 3rd party packages.

Unfortunately, I have no time to work on it until September.

Important! I gonna rebase and clean this PR few times. Changes are not final, don't review it unless you could do it again after cleanup. Just want to show current stage of development.

Related issue #6522

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon
cc @reznikartem @FlaverSaver @xvilo

@ybelenko ybelenko added this to the 5.0.0 milestone Aug 24, 2020
@OpenAPITools OpenAPITools deleted a comment from auto-labeler bot Aug 24, 2020
@@ -0,0 +1,88 @@
/*
* Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech)
* Copyright 2018 SmartBear Software
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 wing328 modified the milestones: 5.0.0, 5.0.1 Dec 21, 2020
@wing328 wing328 modified the milestones: 5.0.1, 5.1.0 Feb 8, 2021
@wing328 wing328 removed this from the 5.1.0 milestone Mar 19, 2021
@coudenysj
Copy link

@ybelenko Is this still something you want to move forward with?

If you need any help, please let me know!

@ybelenko
Copy link
Contributor Author

ybelenko commented Dec 3, 2021

@ybelenko Is this still something you want to move forward with?

If you need any help, please let me know!

As it turned out more difficult to get PR approved in this repo than submit PR itself. I have some free time right now, but PHP Slim4 server generator got higher priority for me personally. I would love to take care of other PHP based generators, but don't know when I can finally reach them(there is also my PHP data mocker repo and I want to develop it into useful package ASAP).

@ybelenko ybelenko changed the title [php-symfony5][wip] New PHP Symfony 5 server generator [php-symfony5] New PHP Symfony 5 server generator Mar 18, 2022
@ybelenko ybelenko removed the WIP Work in Progress label Mar 18, 2022
@ybelenko
Copy link
Contributor Author

Closed in favour #11810

@ybelenko ybelenko closed this Mar 18, 2022
@ybelenko ybelenko deleted the 6522_symfony5_server branch March 18, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants