Skip to content

Use the dataType if the baseType is not set #5372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacether merged 5 commits into from
Feb 28, 2020
Merged

Use the dataType if the baseType is not set #5372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
925c7c5
Use the dataType if the baseType is not set
Feb 19, 2020
afd2452
add tests for passing enum as parameter
Feb 20, 2020
a24a4da
updated requirements file in samples
Feb 20, 2020
b141d25
Update spec to explicitly name objects and prevent `inline_object`
Feb 21, 2020
aa66efc
use the correct scripts to generate samples (`bin/openapi3/python-fla…
Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/openapi3/python-flask-petstore-python2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ then
fi

# if you've executed sbt assembly previously it will use that instead.
input=modules/openapi-generator/src/test/resources/3_0/petstore.yaml
input=modules/openapi-generator/src/test/resources/3_0/petstore-with-object-as-parameter.yaml
out_folder=samples/openapi3/server/petstore/python-flask-python2
resources=modules/openapi-generator/src/main/resources/python-flask

Expand Down
2 changes: 1 addition & 1 deletion bin/openapi3/python-flask-petstore.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ then
fi

# if you've executed sbt assembly previously it will use that instead.
input=modules/openapi-generator/src/test/resources/3_0/petstore.yaml
input=modules/openapi-generator/src/test/resources/3_0/petstore-with-object-as-parameter.yaml
out_folder=samples/openapi3/server/petstore/python-flask
resources=modules/openapi-generator/src/main/resources/python-flask

Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/python-flask/controller.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def {{operationId}}({{#allParams}}{{paramName}}{{^required}}=None{{/required}}{{
{{^isFile}}
{{^isUuid}}
if connexion.request.is_json:
{{paramName}} = {{baseType}}.from_dict(connexion.request.get_json()) # noqa: E501
{{paramName}} = {{#baseType}}{{baseType}}{{/baseType}}{{^baseType}}{{#dataType}} {{dataType}}{{/dataType}}{{/baseType}}.from_dict(connexion.request.get_json()) # noqa: E501
{{/isUuid}}
{{/isFile}}
{{/isPrimitiveType}}
Expand Down
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/python-flask/requirements.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
connexion >= 2.5.0; python_version>="3.6"
connexion >= 2.6.0; python_version>="3.6"
Copy link
Contributor

@spacether spacether Feb 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this version?

Copy link
Contributor Author

@JustinBusschau JustinBusschau Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using 2.5.0 I was getting an error about not being able to import FileStorage from werkzeug . The only way I could find to reliably fix this was to upgrade connexion as per this answer to this issue

connexion >= 2.3.0; python_version=="3.5"
connexion >= 2.3.0; python_version=="3.4"
connexion == 2.4.0; python_version<="2.7"
Expand Down
Loading