[Rust Server] Fix panic handling headers #4877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an API which has multiple auth types, we may panic. This is because
in Hyper 0.11, the following code will panic:
as it mixes up an
Authorization<Basic>andAuthorization<Bearer>as bothhave
Authorization:as the header name.This is fixed by using
swagger::SafeHeadersadded inMetaswitch/swagger-rs#90
This code is no longer relevant once the Hyper 0.12 work is merged, but that is a breaking change, so this is put in for the 4.x branch.
Rust Technical Committee
@frol @farcaller @bjgill
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.