-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[kotlin-spring][server] Feat: Add Spring Declarative HTTP Interface support for easy client instantiation #22302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Picazsoo
wants to merge
18
commits into
OpenAPITools:master
Choose a base branch
from
Picazsoo:feat/add-declarative-http-interface-library-to-kotlin-spring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6,359
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve for spring declarative http client
6842bd3 to
371d3f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the functionality proposed in issue 22286. (fixes #22286)
It adds a new library option to kotlin-spring generator called
spring-declarative-http-interface, which allows for generation of Spring Declarative Http Interfaces for simple instantiations of clients that is available since Spring Boot 3.I implemented ability to switch between
ResponseEntity<SomeClassType>wrapped method return types or just plainSomeClassTypeand support for both reactive and non-reactive options.For reactive options I implemented support for both kotlin-native
coroutineapproach (with the exception of not returningFlowfor collections/arrays asFlowis not supported by spring declarative interfaces) as well asreactorapproach with responses wrapped inMonoorFlux.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)I will also dare to tag members of the java-spring technical committee as this is mostly about the Spring aspect and I think the language is not as important - tagging @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg