Skip to content

Conversation

@jheyens
Copy link
Contributor

@jheyens jheyens commented Oct 14, 2025

In case of OAuth, requests may fail with a 401 Unauthorized status code. This means that the Bearer token used for authentication has expired. The generated code correctly renews the token and retries the request. However, the status code (401) is extracted from the first response, which is then evaluated by some logic (e.g. checking for 204 No Content) and finally returned in the ApiResponse object.
This PR fixes the issue for both Jersey2 and Jersey3 by only extracting the status code after the OAuth handling code.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas
@sreeshas
@jfiala
@lukoyanov
@cbornet
@jeff9finger
@karismann
@Zomzog
@lwlee2608
@martin-mfg

…e persisted even if the second request after renewing the Bearer access token succeeded
@wing328 wing328 merged commit ce1e9e0 into OpenAPITools:master Oct 16, 2025
88 checks passed
@wing328
Copy link
Member

wing328 commented Oct 16, 2025

thanks for the fix, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants