Update AWS Go SDK from v1 to v2 in Go client templates (#3) #21653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Update AWS Go SDK from v1 to v2 in Go client templates Co-authored-by: dennismouwen-eye <[email protected]> * Final validation: AWS SDK v2 integration working correctly Co-authored-by: dennismouwen-eye <[email protected]> * Fix AWS v4 signature implementation: retrieve credentials properly from provider Co-authored-by: dennismouwen-eye <[email protected]> * Fix AWS v4 signature payload hash: properly compute SHA-256 hash for request body Co-authored-by: dennismouwen-eye <[email protected]> * Implement proper payload hashing * Revert go.sum file to original state as requested Co-authored-by: dennismouwen-eye <[email protected]> * Revert go.mod and rename import alias from v4 back to awsv4 Co-authored-by: dennismouwen-eye <[email protected]> * Revert go.mod file to original state removing all changes Co-authored-by: dennismouwen-eye <[email protected]> * Rename credentials import to awscredentials alias as requested Co-authored-by: dennismouwen-eye <[email protected]> * Fix spacing * Fix credentials and imports * Update aws sdk to latest version --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dennismouwen-eye <[email protected]> Co-authored-by: Dennis Mouwen <[email protected]>
wing328
reviewed
Jul 29, 2025
| awscredentials "github.com/aws/aws-sdk-go/aws/credentials" | ||
| awsv4 "github.com/aws/aws-sdk-go-v2/aws/signer/v4" | ||
| awscredentials "github.com/aws/aws-sdk-go-v2/credentials" | ||
| "crypto/sha256" |
There was a problem hiding this comment.
thanks for the pr but looks like this line is not indented correctly
|
please follow step 3 to update the samples so that the ci can verify the change |
I did but there were no changed files |
|
tested locally and the result is good. will add some tests for the aws signature option in another PR instead. thanks for the contribution |
|
update: merged #21657 to add a new sample covering the aws signature option |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
… (OpenAPITools#21653) * Update AWS Go SDK from v1 to v2 in Go client templates (OpenAPITools#3) * Initial plan * Update AWS Go SDK from v1 to v2 in Go client templates Co-authored-by: dennismouwen-eye <[email protected]> * Final validation: AWS SDK v2 integration working correctly Co-authored-by: dennismouwen-eye <[email protected]> * Fix AWS v4 signature implementation: retrieve credentials properly from provider Co-authored-by: dennismouwen-eye <[email protected]> * Fix AWS v4 signature payload hash: properly compute SHA-256 hash for request body Co-authored-by: dennismouwen-eye <[email protected]> * Implement proper payload hashing * Revert go.sum file to original state as requested Co-authored-by: dennismouwen-eye <[email protected]> * Revert go.mod and rename import alias from v4 back to awsv4 Co-authored-by: dennismouwen-eye <[email protected]> * Revert go.mod file to original state removing all changes Co-authored-by: dennismouwen-eye <[email protected]> * Rename credentials import to awscredentials alias as requested Co-authored-by: dennismouwen-eye <[email protected]> * Fix spacing * Fix credentials and imports * Update aws sdk to latest version --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: dennismouwen-eye <[email protected]> Co-authored-by: Dennis Mouwen <[email protected]> * Update indenting --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AWS Go SDK from v1 to v2, as v1 reaches end of support on July 31st.
Fixes #21347
@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)