Skip to content

Conversation

@devhl-labs
Copy link
Contributor

Partial fix for #21585

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jul 29, 2025

we suggest users to use name mapping options: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

to handle duplicated names in the output

(we tried adding a numeric suffix before and it turned out no one wants to use a model with properties id1, id2, id3, etc even though it compiles)

@devhl-labs
Copy link
Contributor Author

Why not both? Get it to compile and when they don't like the suffix then use the map. I will concede that numbering could be inconsistent if the yaml or java change, but it should definitely compile one way or another.

@wing328
Copy link
Member

wing328 commented Jul 29, 2025

never said we shouldn't do both or not adding X different ways to handle such case

just sharing what we went through and the feedback from users when trying to handle such case

@wing328 wing328 merged commit df1d562 into OpenAPITools:master Aug 3, 2025
60 checks passed
@devhl-labs devhl-labs deleted the 21585-unique-property-names branch August 3, 2025 17:36
@wing328 wing328 added this to the 7.15.0 milestone Aug 9, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
* started fixing multiple issues

* weather api builds

* added docstring

* ensure property names are unique

* force pr gates to restart

* force pr gates to restart

* force pr gates to restart

* force pr gates to restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants