Skip to content

[Typescript] Fix warning logs for additional properties that have not been set #21630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mattias-Sehlstedt
Copy link
Contributor

Utilizes the Codegen parsing introduced in #18935 to get rid of warnings for incorrectly set additionalProperties when they are not set rather than incorrectly set.

I.e., the client was getting The value (generator's option) must be either boolean or string. Default to "false". for useRxJS when generating a client, even though they had not even stated a value for it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@@ -7093,7 +7091,7 @@ public boolean convertPropertyToBoolean(String propertyKey) {
} else if (booleanValue instanceof String) {
result = Boolean.parseBoolean((String) booleanValue);
} else {
LOGGER.warn("The value (generator's option) must be either boolean or string. Default to `false`.");
LOGGER.warn("The value {} must be either boolean or string. Default to `false`.", propertyKey);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR

can we still keep (generator's option) in the log some users misunderstood this option as a global option instead if I remember correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have readded that information to the log

@Mattias-Sehlstedt Mattias-Sehlstedt force-pushed the typescript-additional-properties branch from 3ca9220 to a537002 Compare July 26, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants