Skip to content

Conversation

@btpnlsl
Copy link
Contributor

@btpnlsl btpnlsl commented Jul 17, 2025

fixes #21564

This PR adds a mustache template file for the Kotlin Spring generator to generate an EnumConverterConfiguration.kt file when the OpenAPI spec has enum or inner enum classes.

By default Spring converts String values to Enum values using the Enum.valueOf method. This won't work for OpenAPI generated enum classes which were done so using a non default enumPropertyNaming setting for the generator.

The Java Spring generator had the same problem in the past and solved it with these PRs: #18259 and #19248

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Kotlin: @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)
Issue reporter: @drnta
Java Spring PRs: @martin-mfg @pstorch

@btpnlsl btpnlsl marked this pull request as ready for review July 17, 2025 21:12
@wing328 wing328 added this to the 7.15.0 milestone Jul 19, 2025
@wing328 wing328 merged commit bfb6938 into OpenAPITools:master Jul 21, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][kotlin-spring] String to Enum conversion fails for enum query parameters with non default enumPropertyNaming

3 participants