Skip to content

Conversation

@hertzsprung
Copy link
Contributor

resolveResponses is needed by swagger-parser>=2.1.23, see swagger-api/swagger-parser#2127

with out this, $referenced response models are not resolved by openapi-generator 7.14.0

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jul 16, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@hertzsprung hertzsprung force-pushed the fix-resolve-responses branch 2 times, most recently from 995f16a to 1b97b41 Compare July 16, 2025 08:42
needed by swagger-parser>=2.1.23, see swagger-api/swagger-parser#2127
@hertzsprung hertzsprung force-pushed the fix-resolve-responses branch from 1b97b41 to 9c920d7 Compare July 16, 2025 08:43
@hertzsprung
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

@wing328 Thanks. Authorship should be fixed now.

@wing328
Copy link
Member

wing328 commented Jul 16, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/16314765462/job/46117546073?pr=21568

please follow step 3 in the checklist to update the samples

@wing328
Copy link
Member

wing328 commented Jul 19, 2025

tested locally and the result is good

diff --git a/api/openapi.yaml b/api/openapi.yaml
index d7139ea..0be52a4 100644
--- a/api/openapi.yaml
+++ b/api/openapi.yaml
@@ -10,7 +10,11 @@ paths:
       operationId: hello
       responses:
         "200":
-          $ref: "#/components/responses/refResponse"
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/hello_200_response"
+          description: a response specification `$ref`erenced from an operation
       x-accepts:
       - application/json
 components:
@@ -19,10 +23,10 @@ components:
       content:
         application/json:
           schema:
-            $ref: "#/components/schemas/inline_object"
+            $ref: "#/components/schemas/hello_200_response"
       description: a response specification `$ref`erenced from an operation
   schemas:
-    inline_object:
+    hello_200_response:
       example:
         responseProperty: responseProperty
       properties:

thanks for the fix

have a nice weekend

@wing328 wing328 merged commit 7ca3fc3 into OpenAPITools:master Jul 19, 2025
55 of 57 checks passed
@wing328 wing328 added this to the 7.15.0 milestone Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants