Generators "scala-sttp" and "scala-sttp4" produce valid code when using APIKeyQuery, APIKeyHeader and APIKeyCookie #13474 #21551
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Generators for
scala-sttp(andscala-sttp4) do not produce valid code (as in, that compiles) when using multiplesecuritySchemes:as you can see, the generated method contains twice the same
apiKeyparameter. On top of that, the query parameter isn't even added to the url of the request.this was reported by myself 3 years ago #13474 and, since I noticed that using
APIKeyCookieproduces the same outcome, and alsoscala-sttp4generator is affected by those issues, i decided to give it finally a go and fix all of those issues.Tests have been added to ensure the generated
DefaultApicontains the required parameters in their expected position.cc @clasnake @shijinkui @ramzimaalej @chameleon82 @Bouillie @Fish86 🙏
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)