Skip to content

Conversation

@ekarcnevets
Copy link
Contributor

@ekarcnevets ekarcnevets commented Jun 28, 2025

Fix issue where period-delimited model names (e.g. microsoft.graph.fido2AuthenticationMethod) were being converted to unwieldy names with "Period" substitutions. Now periods are replaced with underscores like hyphens, resulting in cleaner and more idiomatic Rust identifiers.

@frol @farcaller @richardwhiuk @paladinzh @jacob-pro

Fixes #15254

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Fix issue where period-delimited model names (e.g. microsoft.graph.fido2AuthenticationMethod)
were being converted to unwieldy names with "Period" substitutions. Now periods are replaced
with underscores like hyphens, resulting in cleaner and more idiomatic Rust identifiers.

Fixes OpenAPITools#15254
@ekarcnevets
Copy link
Contributor Author

unsure if this should be targeting 8.0.x since it changes model names?

@wing328
Copy link
Member

wing328 commented Jun 29, 2025

thanks for the PR

we will consider this as a bug fix as other generators are using similar naming convention.

if users need a way to rollback or customize the model name in whatever way they want, they can use the model name mpaping option: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

@wing328 wing328 merged commit 03effd7 into OpenAPITools:master Jun 29, 2025
19 checks passed
@wing328 wing328 added this to the 7.15.0 milestone Jun 29, 2025
@wing328
Copy link
Member

wing328 commented Jun 29, 2025

@ekarcnevets thanks again for the PR which has been merged.

When you've time, can you please PM me via Slack for a few quick questions?

https://join.slack.com/t/openapi-generator/shared_invite/zt-36ucx4ybl-jYrN6euoYn6zxXNZdldoZA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][RUST] New AbstractRustCodegen.java not handling period-delimited model names well.

2 participants