-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
#17876: Rust Server: Update dependency versions -- hyper 1.6, tokio 1.45, etc. #21332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onfig.toml` (OpenAPITools#17876) This is recommended by Rust 1.39: <https://doc.rust-lang.org/cargo/reference/config.html>
d6aa351 to
5fcecae
Compare
|
thanks for the PR please update the samples when you've time |
agreed. another way is to merge this into master and provide rust-server-deprecated for fallback instead so that users can fallback to current setup if they want to |
would be nice if you can run some tests and ideally run it in production to ensure the output is ready for production |
b1e10c7 to
15a35da
Compare
|
Heya, I regenerated samples, and discovered the templates aren't updated in use-cases that weren't in my project. I've progressed it a little more, but the generated sample code doesn't compile yet. Probably best if someone else picks up from here, my workflow is: # in one terminal
./bin/generate-samples.sh ./bin/configs/rust-server-*.yaml || exit
# in another terminal
cd samples/server/petstore/rust-server/output/openapi-v3
cargo run --example server
# then use compile errors as hints where to change |
15a35da to
9795e2c
Compare
what about updating just one of the dependencies (either hyper or tokio) to make all the tests pass first in this PR to start with? |
|
I've picked this up from where you got to @azriel-healthpoint and have done the following.
I think it makes sense to move the changes to a new PR, #21422. @wing328 does that sound acceptable? |
|
can you please review the build failure when you've time? |
See #21422 which I've now fixed up and should supersede this PR. Any objections to closing this one for clarity on where the changes are being made? |
|
agreed. just closed it |
rust-serverhalf.Short version:
8.0.xbranch, but I began the branch offmaster, and I pulled as much time as I can to push it back upstream (sorry 🙇).hyper'sservice_fnrequireshyper::service::service::Serviceto return aRequest<Incoming>. The previous version had aServicereturn anotherService7.0.0-rc1is needed because that depends onhyper 1.x; Feature/174/implement clone for make allow all authenticator Metaswitch/swagger-rs#179 may be of interest.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro