Skip to content

Conversation

@mvehar
Copy link
Contributor

@mvehar mvehar commented Jan 31, 2019

PR checklist

  • [*] Read the contribution guidelines.
  • [*] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [*] Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Issue: #2031
PHP-symfony: In generated controller check if response is not null, not negative value

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me 👍

@ackintosh ackintosh merged commit f4088f8 into OpenAPITools:master Feb 4, 2019
@ackintosh ackintosh added this to the 4.0.0 milestone Feb 4, 2019
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328
Copy link
Member

wing328 commented May 25, 2022

#11810 has been merged to support Symfony 6. Please give it a try and let us know if you've any feedback or question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants