-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[php-symfony] Update to newer jsm serializer version #10763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ybelenko maybe you can help me out with this ? |
With the code or review? Frankly, I'm Symfony newbie, never used it before in real life projects. |
|
Alright @ybelenko, more of a general question, can I update the generated code to just use PHP 7.0 and newer. I know 7.1 and 7.2 are already EOL'ed and 7.3 soon, but we now still support 5.4+. I'm not sure if we are bound to support certain EOL'ed versions. If not I will update this too |
We don't support eol php version. About which one too choose 7.3, 7.4 or 8 we had a discussion at #9200. If you would ask me personally, I don't even think it's really important, because I always overwrite |
|
We've been using these patches/changes for the past 10 days in our test set-up and have not noticed anything out of the ordinary. It would be great if these could get reviewed and approved/merged. @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12) |
|
Hi! I am using the generator in a project with php 8.1.1 and Symfony6. Here my suggested updates: master...sensorario:master. May I help you in this pull request? I've also opened minutes ago #11322 because I did not saw Symfony6 issues. But now that I saw this pull request I hope to give my contribute to complete the pull request. There are other fixes I need and that I do not see in this PR. For example the generation of routing files and return types in some classes included the generated test files. Also service file configuration needs updates. |
We've been using the library already on PHP for some time with backward compatibility to 7.4 (config platform override in composer.json).
However, we want to fully move to PHP 8.0 and we need an updated version of JMS serializer bundle.
THIS MR IS A DRAFT AND STILL NEEDS TO BE TESTED. FEEL FREE TO GENERATE A CLIENT AND TEST IT FOR ME.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x