Skip to content

Code cleanup and performance improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NonSwag merged 100 commits into from
Jun 15, 2024
Merged

Code cleanup and performance improvements #17

NonSwag merged 100 commits into from
Jun 15, 2024

Conversation

@NonSwag
Copy link

@NonSwag NonSwag commented Jun 9, 2024 •
edited
Loading

Description

This PR is rather unorganized, but in general it provides code quality and performance improvements

  • replaced XMaterials with Bukkit Materials
  • reworked how brushes work
  • removed unused and redundant code
  • abstracted brush settings to fight duplication
  • optimized brush algorithms
  • added proper error handling for fawe config creation
  • removed every static access to main class
  • organized almost every file
  • added a new brush called Underlay

Temporarily replaced the old broken surface mode algorithm with a simpler, faster and more intuitive one

known issue: exported brushes cannot be parsed anymore

I tested it quite a bit but cannot yet ensure that nothing else is broken

Checklist

  • I included all information required in the sections above
  • I tested my changes and approved their functionality
  • I ensured my changes do not break other parts of the code
  • Add a setting to the GUI to use either the old or new surface mode
  • Port to fawe brushes (or as temp solution fix the parsing)

david added 30 commits June 8, 2024 01:22
Merge branch 'code-cleanup' of /home/david/IdeaProjects/BetterGoPaint…
ae0f869 
… with conflicts.
Merge remote-tracking branch 'origin/code-cleanup' into code-cleanup
15720e8 
# Conflicts:
#	src/main/java/net/onelitefeather/bettergopaint/BetterGoPaint.java
#	src/main/java/net/onelitefeather/bettergopaint/command/GoPaintCommand.java
removed XMaterials
afdac5a
added brush settings interface
5d42b76
removed static plugin access
b523947
renamed reload method for clarity
5074c10
removed static plugin access
8aaad5c
removed xmaterials
673f166
optimized brushes
1cacea9
optimized algorithms
07015fe
removed unused and redundant code
ffe9c56
added new underlay brush
a7eaacd
organized file
fa9ec9e
properly handle file loading errors
d138af3
only replace solid blocks
d5c92f2
spotless apply
a834651
don't use anonymous class for initialization
bdd6620
removed excessive line breaks
c494382
reformat
afe059f
added isEnabled to brush settings interface
6beca47
remove duplicate code
e4f207f 
temporarily disabled exported player brush
split up checks
46112a1
let surface check only test for non-solid blocks
bec9641
fixed division by 0
1e33a39
made exported player brushes work again
6ecce1f
fixed interaction point
c2bcfb9
use sendRichMessage instead of manually accessing minimessage
0248e9d
moved logging from condition to effect
9c2d9e1
removed suggestPaper as we are a paper-plugin
0ee6bf8
replaced pumpkin with original one
8bead5f
david and others added 20 commits June 12, 2024 16:03
removed stupid try catch and renamed variables and parameters for cla…
6d8cba4 
…rity
replace ampersand with paragraph
5da996e
move parse method to exported player brush class
51b0d96
re-added line break
d661ebf
move parse method to exported player brush class
4e1a1a2
started fixing gradient brush
9d90b8d
fix import
a9dbe94
added constructor to shorten duplicated code
b31d584
just to satisfy sonar
e16f7d1
added nullability information
7544a37
renamed parameter name for clarity
6599fd9
added more docs
0cb1d8f
added more nullability information
55f33fe
recovered original functionality
6294692
fixed file not found
12a67a4
added default brush item setting
b0f3bab
inverted condition
1960162
added permission constants
864bd24
@TheMeinerLP
Replace enum equals with equals operator
d92552d
@TheMeinerLP
Improve readability for world bypass permission
5a695fa
theEvilReaper
theEvilReaper reviewed Jun 13, 2024
View reviewed changes
Copy link

@theEvilReaper theEvilReaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small point to check

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

NonSwag
NonSwag commented Jun 15, 2024
View reviewed changes
Copy link
Author

@NonSwag NonSwag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my standpoint, there is nothing that needs to be addressed anymore.
All bugs, issues, inconsistencies and unwanted side effects that I could find are fixed now.
If you don't have anything to add, this pr is ready to be merged.

@TheMeinerLP TheMeinerLP mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheMeinerLP TheMeinerLP TheMeinerLP approved these changes

@theEvilReaper theEvilReaper Awaiting requested review from theEvilReaper

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NonSwag @TheMeinerLP @theEvilReaper