Blob filesystem: prune blobs #13147
Merged
Blob filesystem: prune blobs #13147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix block proposals in the REST validator client * fix graffiti test * return empty graffiti * fallback to old endpoints * logs * handle 404 * everything passes * review from James * log undecoded value * test fixes and additions --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
* rearrange deadline * naming
beacon-chain/db/filesystem/blob.go
Outdated
| // Prune prunes blobs in the base directory based on the retention epoch. | ||
| // It deletes blobs older than currentEpoch - (retentionEpoch+bufferEpochs). | ||
| // This is so that we keep a slight buffer and blobs are deleted after n+2 epochs. | ||
| func (bs *BlobStorage) Prune(cliCtx *cli.Context, currentSlot primitives.Slot) error { |
There was a problem hiding this comment.
I still think that having the cli.Context as an argument to the blob storage is a code smell.
If you don't want the caller to figure out the retention slot, can you initialize BlobStorage with the flag value?
beacon-chain/db/filesystem/blob.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &BlobStorage{fs: fs, retentionSlot: retentionSlot}, nil |
There was a problem hiding this comment.
Shouldn't you store the flag value instead of computing the retention slot? The retention slot will be something like current_slot - slots_to_keep which changes over time as current_slot advances.
There was a problem hiding this comment.
Good catch, should be fixed now
Co-authored-by: Preston Van Loon <[email protected]>
prestonvanloon
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
To best manage and optimize the storage of data we need to be able to efficiently prune the old and unnecessary data. All data beyond the default slot retention period will be removed.
The actual retention policy has been implemented with a 2 epoch buffer such that the blobs are not readable after n epochs and they are pruned / deleted after n+2 epochs.
Which issues(s) does this PR fix?
Fixes #13108
Other notes for review