Updating Security area screenshots #2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te for new Vertical Navigation
…curity-screenshots
MarkSiedle
commented
Sep 17, 2024
| Sometimes, a team will be granted contributor access to a project, but be restricted in the environments that it can access. By default, Octopus's security system will then prevent members of the team editing [variables](/docs/projects/variables) that apply outside of their allowed environments. During development this can be inconvenient, as variables frequently need to be added in support of new application features. | ||
|
|
||
| ## Why restrict editing of unscoped variables? {#Securityandun-scopedvariables-Whyrestricteditingofun-scopedvariables?} | ||
| ## Why restrict editing of unscoped variables? {#why-restrict-editing-of-unscoped-variables} |
Contributor
Author
There was a problem hiding this comment.
I followed the same approach Steve Fenton used in this previous PR where we encountered this: 2bd1155#diff-1e8a102c0408e76c53dd207562893eff2122c73073bd5e5f1da9dbb7f399b467
And confirmed there's no anchor link references to these that needed updating.
desruc
approved these changes
Sep 18, 2024
Contributor
desruc
left a comment
desruc
left a comment
There was a problem hiding this comment.
I didn't spin this up locally, but I went through each image and confirmed that they are like for like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As owners of the
Securityarea and as part of this request for R&D in Q3, the Backend Foundations Team are updating the screenshots to match the latest Vertical Navigation design (or remove layout concerns from screenshots where appropriate).Reviewer notes:
pnpmversions and you will have a bad time 🙋 . Instead, if you could just eye-ball the image diffs and confirm they are effectively same-same with with the newer design, that would be much appreciated 🙇