Skip to content

add WebSocket_Security_Cheat_Sheet.md #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

add WebSocket_Security_Cheat_Sheet.md #1780

merged 2 commits into from
Sep 8, 2025

Conversation

maheshkukreja
Copy link
Contributor

This PR fixes issue #1716.

As a follow up, we'll need to clean up the HTML5 Security Cheat Sheet to remove websocket related text in there.

@maheshkukreja maheshkukreja mentioned this pull request Sep 3, 2025
Closed
@randomstuff
Copy link

I don't have much data to back it up but I would think that memory(/resource) exhaustion caused by the lack of control flow/backpressure support in many WebSocket implementations may an important security considerations to add in there?

randomstuff
randomstuff reviewed Sep 4, 2025
View reviewed changes
@maheshkukreja
Copy link
Contributor Author

I don't have much data to back it up but I would think that memory(/resource) exhaustion caused by the lack of control flow/backpressure support in many WebSocket implementations may an important security considerations to add in there?

Thanks for the feedback, @randomstuff - I think I addressed your concerns, let me know if there's anything else.

@jmanico
Copy link
Member

jmanico commented Sep 5, 2025

As a follow up, we'll need to clean up the HTML5 Security Cheat Sheet to remove websocket related text in there.

Can you kindly submit this as a separate issue?

jmanico
jmanico approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestion to add to this, but nothing is wrong and its a great start.

@maheshkukreja maheshkukreja mentioned this pull request Sep 5, 2025
Open
@maheshkukreja
Copy link
Contributor Author

As a follow up, we'll need to clean up the HTML5 Security Cheat Sheet to remove websocket related text in there.

Can you kindly submit this as a separate issue?

#1783

mackowski
mackowski approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@mackowski mackowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks @maheshkukreja

@mackowski mackowski merged commit 60e0f6b into OWASP:master Sep 8, 2025
3 checks passed
@maheshkukreja maheshkukreja deleted the maheshkukreja-websocket-security-cheatsheet branch September 8, 2025 17:35
Prasad-JB pushed a commit to Prasad-JB/CheatSheetSeries that referenced this pull request Sep 8, 2025
@maheshkukreja @Prasad-JB
add WebSocket_Security_Cheat_Sheet.md (OWASP#1780)
80b0d0f 
* add WebSocket_Security_Cheat_Sheet.md

* address randomstuff's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmanico jmanico jmanico approved these changes

@mackowski mackowski mackowski approved these changes

+2 more reviewers

@randomstuff randomstuff randomstuff left review comments

@andrzejsydor andrzejsydor andrzejsydor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maheshkukreja @randomstuff @jmanico @andrzejsydor @mackowski