General Markdown Maintenance & Addition of Dockerfile for Easy Testing w/o Python #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `Dockerfile` for containerized local testing. - Updated lint task to cover all markdown files except `node_modules` and `cheatsheets_excluded`. - Resolved markdown lint issues identified in various repository files. - Added additional suggestion for `File_Upload_Cheat_Sheet.md`.
mackowski
requested changes
Aug 1, 2024
|
Even though checks passed @mackowski still has concerns that seem very reasonable. What is next? |
|
I tried to push a commit that removes the section of the CODEOWNERS file with the error, but I'm getting "permission denied" despite the "Maintainers are allowed to edit this pull request" setting. @Jeymz can you take care of it instead? |
szh
reviewed
Aug 5, 2024
|
Hmm, it seems I can do it from the web interface |
szh
approved these changes
Aug 5, 2024
|
Sorry for the lack of response. I don't regularly check github since it's not my primary working repository. It looks like Shlomo was able to resolve the issues. This was not an issue with the update but was an issue with an outdated entry that was still included in the codeowners I believe. Should probably warrant a regular review of those permissions. |
mackowski
approved these changes
Aug 7, 2024
OngDevLab
added a commit
to OngDevLab/CheatSheetSeries
that referenced
this pull request
Aug 7, 2024
…y Testing w/o Python (OWASP#1459)" This reverts commit 9d8e9e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
[TEXT](URL)If your PR is related to an issue, please finish your PR text with the following line:
This PR covers issue N/A.
Thank you again for your contribution 😃