Skip to content

fixed security issue #1350 & #1349 #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonnieBLT merged 2 commits into from
Nov 2, 2023
Merged

fixed security issue #1350 & #1349 #1562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7addc
fixed security issue #1350 & #1349
JisanAR03 Nov 2, 2023
18b6b65
Merge branch 'main' into issue-#1350
DonnieBLT Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions website/static/js/jquery.caret.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,19 @@
$inputor = this.$inputor;
if (oDocument.selection) {
offset = this.getIEOffset(pos);
offset.top += $(oWindow).scrollTop() + $inputor.scrollTop();
offset.left += $(oWindow).scrollLeft() + $inputor.scrollLeft();
// Check if oWindow is a window object by checking for window-specific properties
function isValidWindow(obj) {
return obj && typeof obj === 'object' && 'scrollTo' in obj && obj.document && obj.self === obj;
}
// Then use this function in your conditionals
if (isValidWindow(oWindow)) {
offset.top += $(oWindow).scrollTop();
offset.left += $(oWindow).scrollLeft();
} else {
console.error('oWindow is not a valid window object.');
}
offset.top += $inputor.scrollTop();
offset.left += $inputor.scrollLeft();
return offset;
} else {
offset = $inputor.offset();
Expand Down