Make Save-WebFile more robust #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is awesome! Thanks @everydayintech! |
KatsuhiroWatanabe
added a commit
to KatsuhiroWatanabe/OSD
that referenced
this pull request
Oct 6, 2025
…tion, and improve download reliability - Add support for importing offline OS catalogs in - Get-OSDCloudOperatingSystems.ps1 - Get-OSDCloudOperatingSystemsIndexMap.ps1 - Get-OSDCloudOperatingSystemsIndexes.ps1 - Add offline driver catalog support in OSDCloud.DriverPack.ps1 - Add post-network script execution and optional supression of module auto-update in - Initialize-OSDCloudStartNet.ps1 - OSDCloudTemplate.ps1 - Since PR OSDeploy#316 adresses a simillar improvement, I've removed my changes. (Improve Save-WebFile.ps1 by checking HTTP headers before download)
KatsuhiroWatanabe
added a commit
to KatsuhiroWatanabe/OSD
that referenced
this pull request
Oct 6, 2025
…tion, and improve download reliability - Add support for importing offline OS catalogs in - Get-OSDCloudOperatingSystems.ps1 - Get-OSDCloudOperatingSystemsIndexMap.ps1 - Get-OSDCloudOperatingSystemsIndexes.ps1 - Add offline driver catalog support in OSDCloud.DriverPack.ps1 - Add post-network script execution and optional supression of module auto-update in - Initialize-OSDCloudStartNet.ps1 - OSDCloudTemplate.ps1 - Since PR OSDeploy#316 adresses a simillar improvement, I've removed my changes. (Improve Save-WebFile.ps1 by checking HTTP headers before download)
KatsuhiroWatanabe
added a commit
to KatsuhiroWatanabe/OSD
that referenced
this pull request
Oct 12, 2025
…tion, and improve download reliability - Add support for importing offline OS catalogs in - Get-OSDCloudOperatingSystems.ps1 - Get-OSDCloudOperatingSystemsIndexMap.ps1 - Get-OSDCloudOperatingSystemsIndexes.ps1 - Add offline driver catalog support in OSDCloud.DriverPack.ps1 - Add post-network script execution and optional supression of module auto-update in - Initialize-OSDCloudStartNet.ps1 - OSDCloudTemplate.ps1 - Since PR OSDeploy#316 adresses a simillar improvement, I've removed my changes. (Improve Save-WebFile.ps1 by checking HTTP headers before download)
KatsuhiroWatanabe
added a commit
to KatsuhiroWatanabe/OSD
that referenced
this pull request
Oct 12, 2025
…xecution - Add support for importing offline OS catalogs in - Get-OSDCloudOperatingSystems.ps1 - Get-OSDCloudOperatingSystemsIndexMap.ps1 - Get-OSDCloudOperatingSystemsIndexes.ps1 - Add offline driver catalog support in OSDCloud.DriverPack.ps1 - Add post-network script execution and optional supression of module auto-update in - Initialize-OSDCloudStartNet.ps1 - OSDCloudTemplate.ps1 - removed: Improve Save-WebFile.ps1 by checking HTTP headers before download Due to conflicts with PR OSDeploy#316 affecting Save-WebFile.ps1, my changes have been removed to maintain consistency with the upstream implementation.
KatsuhiroWatanabe
added a commit
to KatsuhiroWatanabe/OSD
that referenced
this pull request
Dec 1, 2025
…xecution - Add support for importing offline OS catalogs in - Get-OSDCloudOperatingSystems.ps1 - Get-OSDCloudOperatingSystemsIndexMap.ps1 - Get-OSDCloudOperatingSystemsIndexes.ps1 - Add offline driver catalog support in OSDCloud.DriverPack.ps1 - Add post-network script execution and optional supression of module auto-update in - Initialize-OSDCloudStartNet.ps1 - OSDCloudTemplate.ps1 - removed: Improve Save-WebFile.ps1 by checking HTTP headers before download Due to conflicts with PR OSDeploy#316 affecting Save-WebFile.ps1, my changes have been removed to maintain consistency with the upstream implementation.
KatsuhiroWatanabe
added a commit
to KatsuhiroWatanabe/OSD
that referenced
this pull request
Dec 1, 2025
…xecution - Add support for importing offline OS catalogs in - Get-OSDCloudOperatingSystems.ps1 - Get-OSDCloudOperatingSystemsIndexMap.ps1 - Get-OSDCloudOperatingSystemsIndexes.ps1 - Add offline driver catalog support in OSDCloud.DriverPack.ps1 - Add post-network script execution and optional supression of module auto-update in - Initialize-OSDCloudStartNet.ps1 - OSDCloudTemplate.ps1 - removed: Improve Save-WebFile.ps1 by checking HTTP headers before download Due to conflicts with PR OSDeploy#316 affecting Save-WebFile.ps1, my changes have been removed to maintain consistency with the upstream implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Failed curl downloads of the OS image resulted in failed OSD. This improvement means that if network connectivity is interrupted for several minutes, the download will continue where it was interrupted. Save-WebFile is more robust against network disconnections and disruptions.
How it works
To resume failed HTTP downloads, this change uses the curl
--continue-atoption if the remote server supports the HTTPAccept-Rangesheader, and retries the download up to ten times using exponential backoff.Example
Working example where the network connection was disrupted for several minutes:
