Skip to content

Conversation

@PhilipFackler
Copy link
Collaborator

@PhilipFackler PhilipFackler commented Oct 16, 2025

Description

This introduces a logging tool so that we can move away from using std::cout/std::cerr directly.

Closes #270
Closes #129

Proposed changes

The new class and its tests were lifted directly from Re::Solve, see here and here.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler added the enhancement New feature or request label Oct 16, 2025
Copy link
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. I have a few suggestions on the target name choices, consolidating some definitions and namespaces.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/logger branch 4 times, most recently from 79ecc89 to bd87794 Compare October 17, 2025 21:01
@nkoukpaizan nkoukpaizan self-requested a review October 20, 2025 14:41
@nkoukpaizan nkoukpaizan merged commit d563882 into develop Oct 20, 2025
6 checks passed
@nkoukpaizan nkoukpaizan mentioned this pull request Oct 21, 2025
7 tasks
@superwhiskers superwhiskers deleted the PhilipFackler/logger branch October 21, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add output management tool to GridKit add a logging faculty

2 participants