fix: change counting logic for case of zero changes #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, In the case where a `tf.diff.txt` is generated, but it contains no changes (e.g. only moves and imports), then the `grep` that looks for lines not starting with `^# ` would find no lines at all, causing `grep` to return a non-zero exit code, which causes the CI/CD workflow to fail. This PR fixes the issue by adding `|| true` to the relevant `grep`. The `true` command will output zero lines with a zero exit code, so it makes a good fallback here when the `grep` fails (because the `wc --lines` that follows will count zero lines).
rdhar
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
This is fantastic, and the timing is superb! This has been plaguing TF-via-PR for a while so I'm grateful you took time out to contribute a fix -- thank you!
|
Thanks for fixing this! The "diff of 0 changes" cut is a little odd, but overall, it works, and fixes the issue we had in #433 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
In the case where a
tf.diff.txtis generated, but it contains no changes (e.g. only moves and imports), then thegrepthat looks for lines not starting with^#would find no lines at all, causinggrepto return a non-zero exit code, which causes the CI/CD workflow to fail.This PR fixes the issue by adding
|| trueto the relevantgrep. Thetruecommand will output zero lines with a zero exit code, so it makes a good fallback here when thegrepfails (because thewc --linesthat follows will count zero lines).