Skip to content

tls: fix HAS_SPACE macro #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tls: fix HAS_SPACE macro #3324

wants to merge 1 commit into from

Conversation

thus
Copy link
Contributor

@thus thus commented Mar 29, 2018

@thus thus requested a review from a team as a code owner March 29, 2018 20:29
@victorjulien victorjulien mentioned this pull request Mar 30, 2018
Closed
@victorjulien
Copy link
Member

Merged as part of #3331, thank you.

victorjulien added a commit to victorjulien/suricata that referenced this pull request Dec 13, 2019
@victorjulien
stream: reject broken ACK packets
fa692df 
Fix evasion posibility by rejecting packets with a broken ACK field.
These packets have a non-0 ACK field, but do not have a ACK flag set.

Bug OISF#3324.

Reported-by: Nicolas Adba
victorjulien added a commit to victorjulien/suricata that referenced this pull request Dec 13, 2019
@victorjulien
stream: reject broken ACK packets
1c63d39 
Fix evasion posibility by rejecting packets with a broken ACK field.
These packets have a non-0 ACK field, but do not have a ACK flag set.

Bug OISF#3324.

Reported-by: Nicolas Adba
(cherry picked from commit fa692df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thus @victorjulien