Skip to content

Conversation

@shmilyGit
Copy link

(t1. tv_usec - t1. tv_usec) is Error, should be (t1. tv_usec - t0. tv_usec)

(t1. tv_usec - t1. tv_usec) is Error, should be (t1. tv_usec - t0. tv_usec)
@github-actions
Copy link

NOTE: This PR may contain new authors.

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. Code looks good, but git message is not compliant.

Please have a look at our contribution guidelines.

@victorjulien victorjulien added needs ticket Needs (link to) redmine ticket cla required The author has not yet signed the CLA or CLA signing is pending verification labels Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (8542017) to head (7144287).
⚠️ Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14219   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files        1013     1013           
  Lines      262327   262327           
=======================================
  Hits       220809   220809           
  Misses      41518    41518           
Flag Coverage Δ
fuzzcorpus 63.35% <0.00%> (ø)
livemode 18.75% <0.00%> (-0.01%) ⬇️
pcap 44.61% <0.00%> (+0.02%) ⬆️
suricata-verify 64.89% <100.00%> (+<0.01%) ⬆️
unittests 59.18% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, as per Victor's comment, could you please improve on the commit message to follow our guidelines so we could incorporate your patch?

It could be something like:

util/time: fix internal logic error

[here you can add an explain, like you did]

Be sure to respect the line character limits:
50 character for commit title
72 characters for commit body.

For the commit author name, we follow FirstName LastName, if possible.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch! I've created a ticket for it: https://redmine.openinfosecfoundation.org/issues/8073

If you create a redmine user with our project, I can assign it to you.

@jufajardini jufajardini removed the needs ticket Needs (link to) redmine ticket label Nov 3, 2025
@catenacyber
Copy link
Contributor

Thanks again for this.

I did a new PR in #14307 and improved the code further...

Please feel free to make a new PR with your commit if you sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla required The author has not yet signed the CLA or CLA signing is pending verification

Development

Successfully merging this pull request may close these issues.

4 participants