-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update util-time.c, Internal logic error in function TimeDifferenceMicros() . #14219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(t1. tv_usec - t1. tv_usec) is Error, should be (t1. tv_usec - t0. tv_usec)
|
NOTE: This PR may contain new authors. |
victorjulien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this. Code looks good, but git message is not compliant.
Please have a look at our contribution guidelines.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14219 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 1013 1013
Lines 262327 262327
=======================================
Hits 220809 220809
Misses 41518 41518
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, as per Victor's comment, could you please improve on the commit message to follow our guidelines so we could incorporate your patch?
It could be something like:
util/time: fix internal logic error
[here you can add an explain, like you did]
Be sure to respect the line character limits:
50 character for commit title
72 characters for commit body.
For the commit author name, we follow FirstName LastName, if possible.
jufajardini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patch! I've created a ticket for it: https://redmine.openinfosecfoundation.org/issues/8073
If you create a redmine user with our project, I can assign it to you.
|
Thanks again for this. I did a new PR in #14307 and improved the code further... Please feel free to make a new PR with your commit if you sign the CLA |
(t1. tv_usec - t1. tv_usec) is Error, should be (t1. tv_usec - t0. tv_usec)