-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Detect integers 7889 v9 #14181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect integers 7889 v9 #14181
Conversation
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
Ticket: 7889
For keywords that now use the generic integer framework Ticket: 7889
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14181 +/- ##
==========================================
- Coverage 84.18% 84.17% -0.01%
==========================================
Files 1013 1012 -1
Lines 262231 261946 -285
==========================================
- Hits 220747 220482 -265
+ Misses 41484 41464 -20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 28117 |
|
We've decided that for 9, this is the best approach. Removing the |
|
@victorjulien should I do a new rebased PR to run CI with new SV PR ? |
We can try without and see if passes :) |
|
Merged in #14286, thanks! |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7889
Describe changes:
>=, hexadecimal notation, etc..Still one left to do :
ip_protoSV_BRANCH=OISF/suricata-verify#2737
#14071 with nits ntohs fix + new commit with upgrade note