unittests/pool: convert unittests to FAIL/PASS API #14169
Closed
+66
−263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
NOTE: This PR may contain new authors. |
catenacyber
reviewed
Oct 28, 2025
| static void *PoolTestAlloc(void) | ||
| { | ||
| void *ptr = SCMalloc(10); | ||
| if (unlikely(ptr == NULL)) |
There was a problem hiding this comment.
We do this because of cocci :-/
catenacyber
requested changes
Oct 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14169 +/- ##
==========================================
- Coverage 84.46% 84.22% -0.25%
==========================================
Files 1013 1013
Lines 271932 262095 -9837
==========================================
- Hits 229694 220738 -8956
+ Misses 42238 41357 -881
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hello, considering this was a submission related to the Outreachy Contribution round and it's been in the Changes Requested state for a week without new interactions, I'm closing it as stale. If you are still working on this task, please open a new PR with the incorporated feedback. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #6322
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues/6322
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6322
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=