Make analysis add node more user friendly #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of the base node
hengxian-jiang
requested review from
KangJingA,
SantanM,
suwarnoong and
p-hoffmann
as code owners
hengxian-jiang
temporarily deployed
to
github
GitHub Actions
Inactive
hengxian-jiang
temporarily deployed
to
github
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
The PR improves the user experience when adding nodes to an analysis flow by implementing positioning relative to the selected base node and ensuring proper visual feedback through node deselection.
Key changes include:
- Enhanced node positioning logic to place new nodes relative to the base node where the add action originated
- Added node deselection functionality to clear visual state before adding new nodes
- Reorganized imports for better code organization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| (n) => n.id === addNodeTypeDialog.selectedNodeId | ||
| ); | ||
| if (baseNode) { | ||
| const newX = baseNode.position.x - (450 + defaultPosition.gapX); |
There was a problem hiding this comment.
The magic number 450 should be extracted into a named constant or configuration value to improve code maintainability and make the positioning logic more transparent.
Copilot uses AI. Check for mistakes.
KangJingA
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t of the base node
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)