Skip to content

Conversation

KangJingA
Copy link
Collaborator

Merge Checklist

Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.

  • Automated Tests (Jasmine integration tests, Unit tests, and/or Performance tests)
  • Updated Manual tests / Demo Config
  • Documentation (Application guide, Admin guide, Markdown, Readme and/or Wiki)
  • Verified that local development environment is working with latest changes (integrated with latest develop branch)
  • following best practices in code review doc

@KangJingA KangJingA marked this pull request as ready for review September 1, 2025 09:07
@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 09:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues in the analysis UI flow and jobplugin functionality by removing an incorrect output configuration and fixing authentication token handling.

  • Removes incorrect ModuleSpecification output from a node configuration
  • Adds proper null checking for node connections in the flow panel
  • Simplifies token extraction in the Prefect controller by returning the raw authorization header

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ui/apps/analysis/src/features/flow/containers/Node/NodeTypes/index.ts Removes incorrect outputs configuration from node choice mapping
ui/apps/analysis/src/features/flow/containers/Flow/FlowPanel/FlowPanel.tsx Adds null checking before creating edge connections
functions/jobplugins/src/controllers/PrefectController.ts Simplifies token extraction to return raw authorization header

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants