-
Notifications
You must be signed in to change notification settings - Fork 5
fix analysis UI and jobplugin #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues in the analysis UI flow and jobplugin functionality by removing an incorrect output configuration and fixing authentication token handling.
- Removes incorrect
ModuleSpecification
output from a node configuration - Adds proper null checking for node connections in the flow panel
- Simplifies token extraction in the Prefect controller by returning the raw authorization header
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
ui/apps/analysis/src/features/flow/containers/Node/NodeTypes/index.ts | Removes incorrect outputs configuration from node choice mapping |
ui/apps/analysis/src/features/flow/containers/Flow/FlowPanel/FlowPanel.tsx | Adds null checking before creating edge connections |
functions/jobplugins/src/controllers/PrefectController.ts | Simplifies token extraction to return raw authorization header |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
develop
branch)