[e2e] cdm creation test #684
Conversation
Zhimin-arya
requested review from
csafreen,
SantanM,
satish-a0,
suwarnoong and
p-hoffmann
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive end-to-end test for CDM (Clinical Data Model) creation functionality. The test covers the complete workflow from creating a CDM configuration to setting up Patient Analytics, managing duplications, and cleaning up test data.
- Implements automated testing for CDM configuration creation and management
- Covers Patient Analytics configuration setup and validation
- Tests duplication and cleanup workflows for configurations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| await page.locator('input[name="identifier"]').fill('admin') | ||
|
|
||
| await page.locator('input[name="password"]').click() | ||
| await page.locator('input[name="password"]').fill('Updatepassword12345') |
There was a problem hiding this comment.
Hard-coded credentials in test code pose a security risk. Consider using environment variables or a secure configuration file for sensitive test data.
| await page.locator('input[name="password"]').fill('Updatepassword12345') | |
| const testPassword = process.env.TEST_PASSWORD; | |
| if (!testPassword) { | |
| throw new Error('Environment variable TEST_PASSWORD is not set.'); | |
| } | |
| await page.locator('input[name="password"]').fill(testPassword) |
Copilot uses AI. Check for mistakes.
| await page.getByRole('textbox', { name: 'Title Enter name for' }).fill('TestConfig101') | ||
| await page.waitForTimeout(1000) | ||
| await page.getByRole('button', { name: 'Create', exact: true }).click() | ||
| await page.waitForTimeout(1000) |
There was a problem hiding this comment.
Hard-coded timeouts can make tests flaky. Consider using page.waitForLoadState() or waiting for specific elements to be visible instead of arbitrary timeouts.
| await page.waitForTimeout(1000) | |
| await page.getByRole('button', { name: 'Create', exact: true }).waitFor({ state: 'enabled' }) | |
| await page.getByRole('button', { name: 'Create', exact: true }).click() | |
| await page.locator('[id*="--pageMxConfigUI-title-inner"]').waitFor({ state: 'visible' }) |
Copilot uses AI. Check for mistakes.
No description provided.