Fixes around pc freshness and reachability #737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
zapashcanon
reviewed
Jul 11, 2025
zapashcanon
reviewed
Jul 11, 2025
| | hd :: tl -> begin | ||
| let pc_to_check = List.fold_left Symbolic_value.Bool.and_ hd tl in | ||
| let pc_to_check = | ||
| Symbolic_path_condition.slice (Thread.pc thread) pc_to_check |
There was a problem hiding this comment.
A call to slice can only be done if there was a call to Symbolic_path_condition.add before.
zapashcanon
reviewed
Jul 11, 2025
| false | ||
| in | ||
| let* () = check_reachability in |
There was a problem hiding this comment.
I don't understand the purpose one this check
zapashcanon
reviewed
Jul 11, 2025
| @@ -484,18 +495,22 @@ module Make (Thread : Thread_intf.S) = struct | |||
| in | |||
| let this_val_branch = | |||
| let* () = add_breadcrumb (Int32.to_int i) in | |||
| let+ () = add_pc this_value_cond in | |||
| let* () = add_pc this_value_cond in | |||
| let+ () = modify_thread Thread.mark_pending_pc_done in | |||
There was a problem hiding this comment.
So this is adding something to the pending PC and then emptying the pending PC immediately?
|
I decided to merge #739 instead. It makes reasoning easier, as eager pruning of infeasible path is much more easier to explain and maintain as an invariant. I think it may makes sense to explore lazy pruning in the future, but I'd prefer to start with the easier version for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #566 (both reproducing examples)