[14.0][ADD] stock_resupply_order #2412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
from
f703e5c to
e06d1c2
Compare
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
from
e06d1c2 to
27e2ff7
Compare
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
from
27e2ff7 to
d1ffd9c
Compare
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
from
03329ca to
a9c6661
Compare
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
from
a9c6661 to
54a9ecc
Compare
nico-foodles
approved these changes
Aug 28, 2025
petrus-v
reviewed
Sep 2, 2025
Comment on lines
+150
to
+185
| def _get_existing_quants(self): | ||
| """ | ||
| Get stock quants at the targeted location. Override if you need to | ||
| apply specific constraints. | ||
| """ | ||
|
|
||
| self.ensure_one() | ||
|
|
||
| return ( | ||
| self.env["stock.quant"] | ||
| .sudo() | ||
| .read_group( | ||
| domain=[ | ||
| ("location_id", "=", self.location_id.id), | ||
| ( | ||
| "product_id", | ||
| "in", | ||
| self.stock_resupply_order_lines.product_id.ids, | ||
| ), | ||
| ], | ||
| # Cant aggregate available_quantity here. | ||
| fields=["product_id", "quantity:sum", "reserved_quantity:sum"], | ||
| groupby=["product_id"], | ||
| orderby="product_id", | ||
| lazy=False, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I suppose other part of the source code would be easier to read if this return a dict (using a default dict) some thing likes:
available_quantities: dict[int, int] = defaultdict(int)
for group in ...read_group():
product_id = group...
available_quantity = physic - reserved
available_quantities[product_id] = available_quantity
``
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
3 times, most recently
from
8da3ceb to
9e12e98
Compare
StephaneMangin
approved these changes
Sep 11, 2025
| "stock.picking", | ||
| compute="_compute_picking_ids", | ||
| string="Generated stock pickings", | ||
| readonly=True, |
There was a problem hiding this comment.
Suggested change
| readonly=True, |
By default for a simple compute
There was a problem hiding this comment.
# by default, computed fields are not stored, computed in superuser
# mode if stored, not copied (unless stored and explicitly not
# readonly), and readonly (unless inversible)
| ) | ||
|
|
||
| picking_count = fields.Integer( | ||
| string="Picking count", compute="_compute_picking_ids", readonly=True |
There was a problem hiding this comment.
Suggested change
| string="Picking count", compute="_compute_picking_ids", readonly=True | |
| string="Picking count", compute="_compute_picking_ids" |
Same
|
This PR has the |
1 similar comment
|
This PR has the |
StephaneMangin
approved these changes
Sep 11, 2025
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
2 times, most recently
from
2221a40 to
7be62d4
Compare
ltabis
force-pushed
the
14.0-add-stock_resupply_order
branch
from
7be62d4 to
71ece6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new model to create a procurement that takes available stock at the targeted location into account when creating pickings.