Skip to content

[15.0][IMP] stock_inventory_verification_request: improvements in order to see in the tree view who has processed the svr and some minor improvements #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

[15.0][IMP] stock_inventory_verification_request: improvements in order to see in the tree view who has processed the svr and some minor improvements #2273

merged 1 commit into from
Sep 25, 2025

Conversation

JoanSForgeFlow
Copy link
Contributor

Improvements in order to see in the tree view who has processed the SVR and other minor improvements

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-imp-stock_inventory_verification_request-report branch 4 times, most recently from 44dc460 to ba9d055 Compare February 25, 2025 11:13
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 29, 2025
LoisRForgeFlow
LoisRForgeFlow reviewed Jun 30, 2025
View reviewed changes
stock_inventory_verification_request/models/stock_slot_verification_request.py
Comment on lines 45 to 47
inventory_id = fields.Many2one(
comodel_name="stock.inventory", string="Inventory Adjustment", readonly=True
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoanSForgeFlow Why do you remove this link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @LoisRForgeFlow ,

I removed this field because there was no logic implemented to populate it.

However, since this module already depends on stock_inventory and the quants already have current_inventory_id, it's very easy to implement the logic to fill this field.
I will re-add the field and include the missing logic so that it is properly populated.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 6, 2025
@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-imp-stock_inventory_verification_request-report branch 2 times, most recently from 7de9506 to 3ea402b Compare September 25, 2025 09:54
AaronHForgeFlow
AaronHForgeFlow approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@JoanSForgeFlow
[IMP] stock_inventory_verification_request: improvements in order to …
723b69c 
…see in the tree view who has processed the svr and some minor improvements
@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-imp-stock_inventory_verification_request-report branch from 3ea402b to 723b69c Compare September 25, 2025 10:47
LoisRForgeFlow
LoisRForgeFlow approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2273-by-LoisRForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit af6e3e8 into OCA:15.0 Sep 25, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d5797e3. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-imp-stock_inventory_verification_request-report branch September 25, 2025 15:27
@JoanSForgeFlow JoanSForgeFlow mentioned this pull request Sep 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

+1 more reviewer

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanSForgeFlow @OCA-git-bot @AaronHForgeFlow @LoisRForgeFlow