[18.0][MIG] stock_packaging_calculator_packaging_level: Migration to 18.0 #2234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
74902ab to
689b450
Compare
|
/ocabot migration stock_packaging_calculator_packaging_level |
|
@Kimkhoi3010 Thanks for this. To help reviewers, could you add the link to the depending PR in this one's description ? Thanks |
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
689b450 to
1b06d8f
Compare
rousseldenis
approved these changes
Jan 16, 2025
TDu
approved these changes
Jan 28, 2025
jbaudoux
reviewed
Mar 8, 2025
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
3 times, most recently
from
c745ca5 to
c4fff18
Compare
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
c4fff18 to
c98b378
Compare
…ging_calculator_packaging_level
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_packaging_calculator_packaging_level Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_packaging_calculator_packaging_level/it/
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
c98b378 to
3168b87
Compare
jbaudoux
requested changes
Mar 12, 2025
Comment on lines
10
to
11
| def _packaging_name_getter(self, packaging): | ||
| return packaging.packaging_level_id.name |
There was a problem hiding this comment.
I would not change that as this is called when there is no packaging level
| sep = "" if compact_mode else " " | ||
| # Override to use packaging level code | ||
| if packaging and packaging.packaging_level_id: | ||
| name = packaging.packaging_level_id[qty_by_packaging_level_fname] |
There was a problem hiding this comment.
Suggested change
| name = packaging.packaging_level_id[qty_by_packaging_level_fname] | |
| name = packaging.packaging_level_id.get(qty_by_packaging_level_fname, "code") |
| "license": "LGPL-3", | ||
| "application": False, | ||
| "installable": True, | ||
| "auto_install": True, |
There was a problem hiding this comment.
I would make it optional. It should be up to the user to choose to display by packaging name or level code
Suggested change
| "auto_install": True, | |
| "auto_install": False, |
Comment on lines
1
to
3
| Glue module for stock_packaging_calculator and product_packaging_type. | ||
|
|
||
| Mainly to use packaging type's code instead of packaging's name. |
There was a problem hiding this comment.
Suggested change
| Glue module for stock_packaging_calculator and product_packaging_type. | |
| Mainly to use packaging type's code instead of packaging's name. | |
| Modify the string representation of the quantities by packaging. Use the packaging level code instead of the packaging name. | |
| For example, instead of "1 Pallet, 2 Big Box, 7 Box, 10 Units", you get "1PL, 2TU, 7CU, 10 Units" |
jbaudoux
requested changes
Mar 13, 2025
There was a problem hiding this comment.
To move to product-attribute and rename into product_packaging....
Following #2173 (comment)
| # Copyright 2021 Camptocamp SA | ||
| # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) | ||
| { | ||
| "name": "Stock packaging calculator packaging level", |
There was a problem hiding this comment.
Suggested change
| "name": "Stock packaging calculator packaging level", | |
| "name": "Product packaging calculator packaging level", |
| "application": False, | ||
| "installable": True, | ||
| "auto_install": True, | ||
| "depends": ["stock_packaging_calculator", "product_packaging_level"], |
There was a problem hiding this comment.
Suggested change
| "depends": ["stock_packaging_calculator", "product_packaging_level"], | |
| "depends": ["product_packaging_calculator", "product_packaging_level"], |
There was a problem hiding this comment.
PR here: OCA/product-attribute#1932
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
3168b87 to
22d6efd
Compare
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
22d6efd to
45311d7
Compare
…packaging_calculator_packaging_level
Kimkhoi3010
force-pushed
the
18.0-mig-stock_packaging_calculator_packaging_level
branch
from
45311d7 to
97977bd
Compare
|
Hi @jbaudoux, I updated by your comments, and created a new PR OCA/product-attribute#1933 to OCA/product-attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.