[16.0][FIX] stock_request: fix handling of expected_date #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @etobella, @LoisRForgeFlow, |
matt454357
force-pushed
the
16.0-fix_stock-request_expected-date
branch
2 times, most recently
from
9d44892 to
b510a87
Compare
fixes OCA#69 When creating a new stock request, use the expected date provided by the user. When duplicating a stock request, copy the expected date.
matt454357
force-pushed
the
16.0-fix_stock-request_expected-date
branch
from
b510a87 to
54bbb07
Compare
Author
|
@etobella, @LoisRForgeFlow, I would appreciate a review on this PR, if you have the time. |
Author
|
@pedrobaeza would you mind reviewing this? |
matt454357
commented
Nov 6, 2025
| order = self.env["stock.request.order"].browse(upd_vals["order_id"]) | ||
| upd_vals["expected_date"] = order.expected_date | ||
| else: | ||
| elif not upd_vals.get("expected_date"): |
Author
There was a problem hiding this comment.
Only get a new expected date when the user has not specified one.
Member
|
Sorry, not involved too much with this module. |
matt454357
commented
Nov 6, 2025
| if upd_vals.get("name", "/") == "/": | ||
| upd_vals["name"] = self.env["ir.sequence"].next_by_code("stock.request") | ||
| if "order_id" in upd_vals: | ||
| if upd_vals.get("order_id"): |
Author
There was a problem hiding this comment.
Because sometimes order_id = False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69
When creating a new stock request, use the expected date provided by the user.
When duplicating a stock request, copy the expected date.