Skip to content

Conversation

@carlos-lopez-tecnativa
Copy link
Contributor

  • Convert max_quantity to a computed field.
  • Prevent deletion of records in the done state.
  • Improve the lot suggestion process by creating a new Transient model and using a single many2one field. This allows users to search and filter more easily. The technical reason for this change is that Odoo caches form views, so selections are not always updated—only on the first load.
  • Increase test coverage.

TODO: Add multi-company support?

TT54355

@Tecnativa @pedrobaeza @chienandalu @sergio-teruel could you please review this.

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-stock_return_request branch from 4a11e26 to b9f8610 Compare February 4, 2025 18:41
@pedrobaeza
Copy link
Member

/ocabot migration stock_return_request

@carlos-lopez-tecnativa
Copy link
Contributor Author

ping @chienandalu @sergio-teruel

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-stock_return_request branch 2 times, most recently from 3645338 to 595bf65 Compare February 12, 2025 18:01
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@carlos-lopez-tecnativa
Copy link
Contributor Author

ping @chienandalu

@carlos-lopez-tecnativa
Copy link
Contributor Author

@chienandalu friendly reminder, could you please review this PR?

chienandalu and others added 15 commits April 8, 2025 08:11
When the CI is very fast, the moves could have the same datetime, so the
date asc order would not work as expected
Currently translated at 100.0% (122 of 122 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_return_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_return_request/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_return_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_return_request/
The string to translate shouldn't be put with triple quote, or it
becomes a hell to be translated. The Spanish translation was also
incorrect, provoking the new PO linter to fail.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_return_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_return_request/
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-stock_return_request branch from 595bf65 to 154f41f Compare April 8, 2025 13:11
@carlos-lopez-tecnativa
Copy link
Contributor Author

@carlosdauden could you please review this?

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-stock_return_request branch from 154f41f to 9db5344 Compare April 8, 2025 14:33
…text

Prevent comparing a browse_record with only an ID.
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-56-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2016865 into OCA:18.0 Apr 9, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bbd43ca. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-stock_return_request branch April 9, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.